Skip to content

chore: remove duplicate entry from .gitignore #5090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2022
Merged

chore: remove duplicate entry from .gitignore #5090

merged 1 commit into from
Jul 30, 2022

Conversation

jbampton
Copy link
Member

Description

Removed duplicate .gitignore entry

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-io
Copy link

codecov-io commented Mar 14, 2021 •
edited
Loading

Codecov Report

Merging #5090 (3e1cd30) into master (625fc5b) will decrease coverage by 6.88%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5090      +/-   ##
==========================================
- Coverage   82.15%   75.26%   -6.89%     
==========================================
  Files         213      206       -7     
  Lines       10316    10051     -265     
  Branches      452      449       -3     
==========================================
- Hits         8475     7565     -910     
- Misses       1841     2486     +645
Impacted Files Coverage Δ
...core/database/cosmosdb/RxObservableImplicits.scala 0.00% <0.00%> (-100.00%) ⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala 0.00% <0.00%> (-100.00%) ⬇️
...e/database/cosmosdb/cache/ChangeFeedConsumer.scala 0.00% <0.00%> (-100.00%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0.00% <0.00%> (-95.85%) ⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala 0.00% <0.00%> (-93.90%) ⬇️
...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala 0.00% <0.00%> (-92.31%) ⬇️
...enwhisk/connector/kafka/KamonMetricsReporter.scala 0.00% <0.00%> (-83.34%) ⬇️
...e/database/cosmosdb/cache/KafkaEventProducer.scala 0.00% <0.00%> (-78.58%) ⬇️
...whisk/core/database/cosmosdb/CosmosDBSupport.scala 0.00% <0.00%> (-74.08%) ⬇️
...ore/database/azblob/AzureBlobAttachmentStore.scala 11.53% <0.00%> (-60.58%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 625fc5b...3e1cd30. Read the comment docs.

upgle
upgle approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@upgle upgle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you for finding the duplicated line.

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2021 •
edited
Loading

Codecov Report

Merging #5090 (3e1cd30) into master (625fc5b) will decrease coverage by 33.32%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #5090       +/-   ##
===========================================
- Coverage   82.19%   48.86%   -33.33%     
===========================================
  Files         213      240       +27     
  Lines       10316    17709     +7393     
  Branches      452      774      +322     
===========================================
+ Hits         8479     8654      +175     
- Misses       1837     9055     +7218
Impacted Files Coverage Δ
...core/database/cosmosdb/RxObservableImplicits.scala 0.00% <0.00%> (-100.00%) ⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala 0.00% <0.00%> (-100.00%) ⬇️
...e/database/cosmosdb/cache/ChangeFeedConsumer.scala 0.00% <0.00%> (-100.00%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0.00% <0.00%> (-95.85%) ⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala 0.00% <0.00%> (-93.90%) ⬇️
...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala 0.00% <0.00%> (-92.31%) ⬇️
...enwhisk/connector/kafka/KamonMetricsReporter.scala 0.00% <0.00%> (-83.34%) ⬇️
...e/database/cosmosdb/cache/KafkaEventProducer.scala 0.00% <0.00%> (-78.58%) ⬇️
...whisk/core/database/cosmosdb/CosmosDBSupport.scala 0.00% <0.00%> (-74.08%) ⬇️
...ore/database/azblob/AzureBlobAttachmentStore.scala 7.54% <0.00%> (-64.57%) ⬇️
... and 114 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@upgle upgle merged commit d92485c into apache:master Jul 30, 2022
@jbampton jbampton deleted the fix-gitignore branch July 30, 2022 07:53
msciabarra pushed a commit to nuvolaris/openwhisk that referenced this pull request Nov 23, 2022
@jbampton @michele-sciabarra
chore: remove duplicate entry from .gitignore (apache#5090)
2800221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upgle upgle upgle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbampton @codecov-io @codecov-commenter @upgle